-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set require "administrate/version" #2491
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, we are not requiring that file except in gemspec https://github.com/search?q=repo%3Athoughtbot%2Fadministrate%20version&type=code
Which version did you upgrade from? Are you doing anything with the FWIW, that line has been in there for 9 years. I'd not expect that to be a problem because of that version because of that: https://github.com/thoughtbot/administrate/blame/main/administrate.gemspec#L3 |
We are also facing this on this pr: chatwoot/chatwoot#8741 here is the trace I think it throws this error when
|
I did update from 0.19.0 to 0.20.0. v0.19.0...v0.20.0#diff-3c290ae4fe2e0753529c6c6dfb1ccaa391ac53237bbd0ca7de07b5f60cd68732R43 I think previous version did not use The example app read from gemspec, so it may work |
In thoughtbot#2479, we switched to using a dedicated `ActiveSupport::Deprecation` instance to handle a deprecation warning. Unfortunately, in some circumstances, we reference the `VERSION` constant when it's not been loaded, which seems to happen when we render the deprecation warnings.
2bcd8f5
to
195126d
Compare
Ah hah, yes, that all adds up. I think this is the right way to go then. I can't think of a good way to test this, at least with what structure we have already, so I'm not going to let that hold us back. |
I've just pushed v0.20.1 which includes this fix, thanks for reporting and providing a solution! |
We met
uninitialized constant Administrate::VERSION
error after v0.20.0.How to reproduce
Remove
require "administrate/version"
from administrate.gemspec.