Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added several hook points in the layout file #2574

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

goosys
Copy link
Contributor

@goosys goosys commented May 1, 2024

Added several hook points for customization.
This simplifies the process of adding elements to parts of the page, allowing for customization without the need to copy existing templates.

@nickcharlton
Copy link
Member

Thanks! Could you add a section to the docs to cover this addition?

@goosys
Copy link
Contributor Author

goosys commented Sep 25, 2024

@nickcharlton Thank you for the review!
I’ve added the docs, but how does it look? Please feel free to point out any suggestions for the location or wording if needed.

Copy link
Member

@nickcharlton nickcharlton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks!

Just a few Markdown points.

docs/customizing_page_views.md Outdated Show resolved Hide resolved
docs/customizing_page_views.md Outdated Show resolved Hide resolved
@goosys goosys force-pushed the add-hooks-to-page-layouts branch from cc8d779 to b1edb67 Compare September 29, 2024 06:01
@goosys
Copy link
Contributor Author

goosys commented Sep 29, 2024

@nickcharlton
Thank you for the review. I have addressed the points you mentioned.

This commit allows us to add content in some additional places, from
around the header to around the main body, which means users can more
easily customise their templates without needing to override the whole
file.
@nickcharlton nickcharlton force-pushed the add-hooks-to-page-layouts branch from b1edb67 to b68757f Compare September 30, 2024 11:15
@nickcharlton
Copy link
Member

Great, thanks!

@nickcharlton nickcharlton merged commit 0829202 into thoughtbot:main Sep 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants