Consistent translation for BelongsTo Fields across pages #2590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, if a model (e.g., `Customer`) has a translation (e.g., `Client`), the translated label is correctly displayed on the Show page. However, on the Edit and New pages, the original label (e.g., `Customer`) is displayed instead of the translated one. This commit ensures that the translated label for `BelongsTo` fields is consistently displayed across all pages. Specifically, it modifies the `belongs_to`/`_form` partial to display the translated label (if available) instead of the original one. Fixes thoughtbot#625.
|
Wonderful, thanks! I just rebased to reword the commit message (and add a reference to the original issue). I'll merge it once the suite passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an inconsistency in the display of translated labels for
BelongsTofields across different pages in the application.Currently, if a model (e.g.,
Customer) has a translation (e.g.,Client), the translated label is correctly displayed on theShowpage. However, on theEditandNewpages, the original label (e.g.,Customer) is displayed instead of the translated one.This PR ensures that the translated label for
BelongsTofields is consistently displayed across all pages. Specifically, it modifies thebelongs_to/_formpartial to display the translated label (if available) instead of the original one.This change enhances the user experience by providing consistent and localized labels across the application.