Add diff-check to catch missing Appraisal runs #2609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This puts an action I wrote a little while ago in, as I was waiting for a time it actually would fail correctly. I also found a bug in That said, we're seeing the
|
nickcharlton
force-pushed
the
nc-add-diff-check-for-appraisal
branch
from
febcf60 to
67de03d
Compare
nickcharlton
force-pushed
the
nc-add-diff-check-for-appraisal
branch
2 times, most recently
from
5112a10 to
83e32a6
Compare
If we forget to run `bundle exec appraisal`, which is not uncommon, it means we miss when the appraisal files change. This should catch it and fail the build, reporting back that they changed and hinting at what should be done. https://github.com/nickcharlton/diff-check https://nickcharlton.net/posts/diff-check-github-action
nickcharlton
force-pushed
the
nc-add-diff-check-for-appraisal
branch
from
6bd66c7 to
67dfb56
Compare
|
After discovering some more weird behaviour in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we forget to run
bundle exec appraisal, which is not uncommon, it means we miss when the appraisal files change. This should catch it and fail the build, reporting back that they changed and hinting at what should be done.https://github.com/nickcharlton/diff-check
https://nickcharlton.net/posts/diff-check-github-action