Adjust the field path to fit Ruby conventions #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-lliope
added a commit
to thoughtbot/administrate-field-image
that referenced
this pull request
Feb 14, 2016
Problem: Administrate is updating its field paths in thoughtbot/administrate#467. This change breaks the path references in this gem. Solution: Follow Administrate's lead and update the field paths.
Problem: File paths within the `lib` folder have inconsistent pluralization. According to ruby convention, each class should be stored in a file where the parent directories correspond to the namespaces of the class. For us, our `Administrate::Field` classes are stored in `administrate/fields`. The incorrect pluralization breaks Ruby's convention. Solution: Move `lib/administrate/fields` -> `lib/administrate/field`.
kkelleey
added a commit
to kkelleey/blog
that referenced
this pull request
May 5, 2016
This is to conform to the changes in the Administrate API thoughtbot/administrate#467 I should have caught this sooner, it was causing errors on admin/cities and admin/countries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
File paths within the
libfolder have inconsistent pluralization.According to ruby convention, each class should be stored in a file
where the parent directories correspond to the namespaces of the class.
For us, our
Administrate::Fieldclassesare stored in
administrate/fields.The incorrect pluralization breaks Ruby's convention.
Solution:
Move
lib/administrate/fields->lib/administrate/field.