Modify has_many field show

[jasontwong]

Resolves #440

Why:

• The template is rendering the incorrect partial.

This change addresses the need by:

• Create field helper collection_partial(namespace).
• Update has_many/_show.html.erb to use new helper.

[jasontwong]

Can anyone rerun the tests on CircleCI? It looks like a non-code issue cause it to fail.

[wjlroe]

I've just hit this bug, is there anything that needs to be done for it to be merged?

[hughfm]

Has there been a decision on whether this is the right way to fix this? I'd love to see a solution asap, and would be happy to help work towards one if there are any concerns about what has been proposed here.

[hughfm]

@jasontwong thanks for your fix here, I've been using it in my application and all good so far! One thought though...

say for example you have a User class that has_many :posts, and we are rendering a user's posts on their show page... if we have overridden the posts/collection partial, this will now be used correctly 👍

if that partial has not been overridden however, it still defaults to the users/collection partial, if that exists. I'm thinking it may make more sense to default straight back to application/collection. What do you think?

[jasontwong]

@hughfm I'm glad it's been working well for you. The only reason why I left it to use the users/collection template was to make the default functionality relate as close to the original code as possible. This would make it easier for those already familiar with the usage to add in this override. I agree that the best way would probably be to use application/collection but I would rather leave it to the administrate team to decide what the default functionality should be.

[hughfm]

Yep that's fair enough @jasontwong, would love to hear thoughts on this from the team..

[allthesignals]

If you're trying to fix this bug in Rails 5, I've merged both the rails5 compatibility branch and this branch here: https://github.com/MAPC/administrate

Include in your Gemfile like this:
gem 'administrate', github: 'MAPC/administrate', branch: 'rails5'

In order to get the fix applied, you do have to generate the related model's partial with rails g administrate:views:index. Thanks for your work, @jasontwong!

[carlosramireziii]

@nickcharlton There's a question here about whether or not this is the right approach.

[nickcharlton]

Hi! I'm just getting around to looking at this now.

I think this is a reasonable approach to the problem. Are we able to test this in both scenarios (using a default collection template, using a custom one)?

[jasontwong]

It's been a while since I looked at this... I'll dig into the testing.

[nickcharlton]

Hi @jasontwong! Did you get anywhere with looking at the testing?

[josephchoe]

Has there been any progress on this?

[nickcharlton]

@jasontwong Did you get a chance to look at this again?

[pablobm]

Closing as there has been no activity for a while. Happy to reopen if someone wants to take over.