Allow to limit route actions #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -79,6 +79,17 @@ def nav_link_state(resource) | |||
| end | |||
| end | |||
|
|
|||
| helper_method :valid_action? | |||
| def valid_action?(name, resource = resource_name) | |||
| !!routes.find do |controller, action| | |||
| if (!event.target.href) { | ||
| var url = $(event.target).closest("tr").data("url"); | ||
|
|
||
| if (url) window.location = url; |
There was a problem hiding this comment.
Expected '{' and instead saw 'window'.
|
Hmm so CircleCI is failing but I don't think it's related to my changes? |
|
@infertux Rebuilding without cache :) |
|
Ping @Graysonwright @BenMorganIO :) |
|
@infertux can you add specs for this please? |
infertux
force-pushed
the
dynamic_routes
branch
from
7451072 to
1379971
Compare
|
@BenMorganIO Sorry about the delay, I added specs. BTW the build is failing because of bundler-audit. |
This allows to limit route actions such as :index and :show in routes.rb and only display these routes in views.
infertux
force-pushed
the
dynamic_routes
branch
from
1379971 to
852d8d9
Compare
|
I'd really love to see this feature make it into the main gem. Any chance of this getting approved? Is there anything I can do to help? |
|
This will cleanly rebase on |
mmagn
added a commit
to demarches-simplifiees/demarches-simplifiees.fr
that referenced
this pull request
Jan 4, 2018
…index This can be reverted when Administrate gem will include this fix : thoughtbot/administrate#597 (>=0.5.0)
mmagn
added a commit
to demarches-simplifiees/demarches-simplifiees.fr
that referenced
this pull request
Jan 4, 2018
…index This can be reverted when Administrate gem will include this fix : thoughtbot/administrate#597 (>=0.5.0)
mmagn
added a commit
to demarches-simplifiees/demarches-simplifiees.fr
that referenced
this pull request
Jan 8, 2018
…index This can be reverted when Administrate gem will include this fix : thoughtbot/administrate#597 (>=0.5.0)
mmagn
added a commit
to demarches-simplifiees/demarches-simplifiees.fr
that referenced
this pull request
Jan 8, 2018
…index This can be reverted when Administrate gem will include this fix : thoughtbot/administrate#597 (>=0.5.0)
mmagn
added a commit
to demarches-simplifiees/demarches-simplifiees.fr
that referenced
this pull request
Jan 8, 2018
…index This can be reverted when Administrate gem will include this fix : thoughtbot/administrate#597 (>=0.5.0)
mmagn
added a commit
to demarches-simplifiees/demarches-simplifiees.fr
that referenced
this pull request
Jan 10, 2018
…index This can be reverted when Administrate gem will include this fix : thoughtbot/administrate#597 (>=0.5.0)
mmagn
added a commit
to demarches-simplifiees/demarches-simplifiees.fr
that referenced
this pull request
Jan 10, 2018
…index This can be reverted when Administrate gem will include this fix : thoughtbot/administrate#597 (>=0.5.0)
tchak
pushed a commit
to tchak/tps
that referenced
this pull request
Aug 9, 2018
…d delete button from index This can be reverted when Administrate gem will include this fix : thoughtbot/administrate#597 (>=0.5.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to limit route actions in
routes.rbby usingonly: [:index, :show]for example and only display these routes in views.