Fix broken sort arrow svg in the resource table #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoangzinh
force-pushed
the
fix_broken_sort_arrow_svg_in_resource_table
branch
from
121f43a to
6a48465
Compare
|
When is this going to be merged? |
nickcharlton
force-pushed
the
fix_broken_sort_arrow_svg_in_resource_table
branch
from
6a48465 to
e2ffce6
Compare
|
Great! Thanks. Going to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue: Broken sort arrow in the resource table #686
I found that, the svg tag isn't set the width and height, so it occupies the parent tag. This is the quick screenshot for this issue:
The result after apply the patch: