Redefine base resource path #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Love it! Can you squash into one commit and merge? |
Before, the base resource path for view generators was a hard-coded string. This was causing issues for some generators. When called without an argument, their sub-generators had the wrong resource path. Replaced the base resource path string with a value object. * Fixes #645
purinkle
force-pushed
the
rw-fix-base-resource-path
branch
from
e9e5e26 to
0e6f9c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the base resource path for view generators was a hard-coded string. This was causing issues for some generators. When called without an argument, their sub-generators had the wrong resource path. Replaced the base resource path string with a value object.