Update instances of bourbon to 5.0.0.beta.7; sass to ~>3.4 #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Wonderful! I was curious that Circle didn't run with this, but it's running fine locally. So I'm going to merge! |
fwolfst
pushed a commit
to fwolfst/administrate
that referenced
this pull request
Mar 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in this issue comment This updates
administrateto use bourbon 5 properly, I hope. Along the way it seemed thesassgem dependency needed to be updated as well.I have to admit these layered dependencies and Appraisal tests are slightly out of my depth, but as far as I can tell all tests pass and a skeleton sample app I set up using Rails 5.0.2 and Ruby 2.3.1 and including these two gems, verbatim:
does work just fine, whereas when trying to use
administrateon its own I got bundler errors like so:Also, I'm not sure of the larger implications of requiring all Administrate users to upgrade to bourbon 5, especially since it seems there may be other issues with bourbon 5 dependencies?
Let me know if anything needs to change or be updated.
Thanks!