Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add refills, refills-style flashes, and specs for updating a resource #760

Merged
merged 1 commit into from
Mar 4, 2017

Conversation

jcmorrow
Copy link
Contributor

@jcmorrow jcmorrow commented Mar 3, 2017

This commit addresses issue #185 where an unsuccessful update threw off
the spacing between fields and labels.

Changes:

  • Add refills to Gemfile
  • Replace flashes component with generated refills flashes component
  • Apply refills class to existing flashes partial
  • Update #have_flash matcher to reflect new class name

@jcmorrow jcmorrow force-pushed the dc-jm-refills-fix-185 branch 3 times, most recently from c64b507 to 6a69aba Compare March 3, 2017 19:12
Unsuccessful updates were resulting in weird form spacing.

Changes:
- Add refills to Gemfile
- Replace `flashes` component with generated refills flashes component
- Apply refills class to existing `flashes` partial
- Update `#have_flash` matcher to reflect new class name
@jcmorrow jcmorrow force-pushed the dc-jm-refills-fix-185 branch from 6ad28fa to feeca6c Compare March 3, 2017 23:58
@jcmorrow jcmorrow merged commit feeca6c into master Mar 4, 2017
@jcmorrow jcmorrow deleted the dc-jm-refills-fix-185 branch March 4, 2017 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant