Update the Appraisal Gemfiles. #784
Conversation
nickcharlton
commented
Mar 17, 2017
•
nickcharlton
commented
- Reduce the bourbon requirement slightly (7 to 6) so we can avoid updating Sass.
- Adds refills, autoprefixer-rails, sentry-raven which were previously merged.
Appraisals
Outdated
| @@ -1,5 +1,5 @@ | |||
| appraise "sass-3-4" do | |||
| gem "sass", "~> 3.4" | |||
| gem "sass", "~> 3.4.22" | |||
There was a problem hiding this comment.
Would this level of specificity cause issues for projects that have versions 3.4.0..3.4.21?
There was a problem hiding this comment.
Ooh, I hadn't thought of that. What do you think would be a better way of specifying it?
There was a problem hiding this comment.
Depends, I think. What does administrate need from .22 that .0 doesn't provide? Looks like it's Bourbon? Can the bourbon version be bumped backwards a little bit to accommodate some flexibility in that realm.
If possible, I'd suggest changing the Administrate sass/bourbon requirements to NOT use any features that are locked into later/younger versions.
There was a problem hiding this comment.
Can the bourbon version be bumped backwards a little bit to accommodate some flexibility in that realm.
Yes, we can and probably should do that.
There was a problem hiding this comment.
I've switched the Bourbon requirement to be 5.0.0.beta.6 or greater and this seems to solve this.
There was a problem hiding this comment.
FYI, I opened thoughtbot/bourbon#1015 on Bourbon to loosen these requirements.
* Bourbon requires sass 3.4.22, which is minor bump. * Adds refills, autoprefixer-rails, sentry-raven which were previously merged.
nickcharlton
force-pushed
the
nc-update-appraisals
branch
from
38150be to
89241f6
Compare
gemfiles/rails42.gemfile
Outdated
| gem "unicorn" | ||
| gem "rails", "~> 4.2.0" | ||
|
|
||
| group :development do | ||
| gem "refills" |
There was a problem hiding this comment.
I suggest removing Refills because it is going through a major rewrite. The gem is likely to go away (or dormant).
The gem is just a generator anyway, so we don’t need to have it to use some of the components.
There was a problem hiding this comment.
Okay, cool! I'll do that in the same PR and merge. Thank you!
From @tysongach: > I suggest removing Refills because it is going through a major rewrite. > The gem is likely to go away (or dormant). > The gem is just a generator anyway, so we don’t need to have it to use > some of the components.
