Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use an array instead of a regex #814

Merged

Conversation

BenMorganIO
Copy link
Collaborator

@BenMorganIO BenMorganIO commented Apr 4, 2017

Sass calls String#start_with? in version 6 on the precompile assets, yet Regex doesn't implement this method leading to an error.

@BenMorganIO BenMorganIO force-pushed the array-instead-of-regex-for-svgs branch from 2259429 to ee1880b Compare April 4, 2017 19:10
Copy link
Member

@nickcharlton nickcharlton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it! Can we keep the .keep out of this commit though?

Rails calls String#start_with? on the precompile assets, yet Regex doesn't implement this method leading to an error.
@BenMorganIO BenMorganIO force-pushed the array-instead-of-regex-for-svgs branch from ee1880b to d39e0f2 Compare April 4, 2017 19:24
@nickcharlton nickcharlton merged commit 78976c2 into thoughtbot:master Apr 4, 2017
@BenMorganIO BenMorganIO deleted the array-instead-of-regex-for-svgs branch April 4, 2017 19:25
iarie pushed a commit to iarie/administrate that referenced this pull request Jun 17, 2017
Rails calls String#start_with? on the precompile assets, yet Regex doesn't implement this method leading to an error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants