Add appraisal and foreman commands to docs #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For contributors that not aware about appraisal and foreman it is hard to know how to run the development server and tests with appraisal.
tysongach
reviewed
May 9, 2017
CONTRIBUTING.md
Outdated
| require no new tests. If you are adding functionality or fixing a bug, | ||
| we need a test! | ||
|
|
||
| 5. Make the test pass. | ||
| 6. Make the test pass. |
There was a problem hiding this comment.
While we’re in here, thoughts on swapping all of these to 1s and having Markdown build the ordered list for us?
There was a problem hiding this comment.
Nice! I did not know about this feature
|
This looks good! Re: |
|
@nickcharlton I see that CI do not use Will we make changes to the |
|
Hmm, I agree. Let's leave it for now. I'd be happy to see another PR, though. |
iarie
pushed a commit
to iarie/administrate
that referenced
this pull request
Jun 17, 2017
For contributors that not aware about appraisal and foreman it is hard to know how to run the development server and tests with appraisal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For contributors that not aware about appraisal and foreman it is hard to know how to run the development server and tests with appraisal.
As a suggestion, it will be good to move the
appraisal installcommand tobin/setup, but not sure how CI will react on this change.