Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update normalize.css and change how we include it #882

Merged
merged 3 commits into from
May 19, 2017
Merged

Conversation

tysongach
Copy link
Contributor

  • Update normalize.css to v7.0.0.
  • Include normalize.css as raw CSS, instead of through RubyGems because
    the normalize-rails gem has fallen much behing the release cycle of
    normalize.css.

@tysongach tysongach added the views-and-styles how administrate looks and is interacted with label May 11, 2017
@BenMorganIO
Copy link
Collaborator

BenMorganIO commented May 12, 2017

I deleted the @houndci comments since you marked that file as excluded (probably to avoid more Hound comments).

Should we place the normalize.css in the vendor folder instead of the app folder?

@tysongach
Copy link
Contributor Author

Should we place the normalize.css in the vendor folder instead of the app folder?

Good thinking! We don’t have a vendor directory in this project, currently. Is that something we can simply add and it will work given that this is a gem/generator? Or will we have to explicitly include it?

@BenMorganIO
Copy link
Collaborator

@tysongach Rails already loads up and checks for a vendor folder by default. So, you're all good.

@nickcharlton
Copy link
Member

@BenMorganIO Is that still the case with a Rails Engine, though?

@BenMorganIO
Copy link
Collaborator

Errr... That's a good question. If we require it from administrate, it should still work... Administrate itself should be aware of a vendor folder. BUT an application should not be fully aware of Administrates vendor folder when it searches a tree. So, I'm going to say yes, but we should test that out. I could be completely wrong.

@tysongach
Copy link
Contributor Author

What’s a good way to test that?

@BenMorganIO
Copy link
Collaborator

BenMorganIO commented May 12, 2017

To test? Make sure normalize.css gets included :p

@tysongach tysongach force-pushed the tg-normalize branch 2 times, most recently from 688e2b6 to d4f5fb3 Compare May 12, 2017 20:29
@tysongach
Copy link
Contributor Author

tysongach commented May 12, 2017

d4f5fb3 places normalize.css in the vendor directory. It appears to be working fine, but I’ve not run the engine or anything, just checked locally.

tysongach added 3 commits May 19, 2017 14:47
- Update normalize.css to v7.0.0.
- Include normalize.css as raw CSS, instead of through RubyGems because
  the normalize-rails gem has fallen much behing the release cycle of
  normalize.css.
@nickcharlton
Copy link
Member

I've tested this on a fresh Rails 5.1 app and it seems fine.

@nickcharlton nickcharlton merged commit ec6491a into master May 19, 2017
@nickcharlton nickcharlton deleted the tg-normalize branch May 19, 2017 14:02
iarie pushed a commit to iarie/administrate that referenced this pull request Jun 17, 2017
* Update normalize.css and change how we include it

- Update normalize.css to v7.0.0.
- Include normalize.css as raw CSS, instead of through RubyGems because
  the normalize-rails gem has fallen much behing the release cycle of
  normalize.css.

* Ignore reset directory from scss-lint

* Put normalize.css in vendor directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
views-and-styles how administrate looks and is interacted with
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants