Nested collection links should honour routes #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
May 10, 2017
spec/features/orders_show_spec.rb
Outdated
|
|
||
| visit admin_order_path(payment.order) | ||
|
|
||
| within('table') do |
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/features/orders_show_spec.rb
Outdated
|
|
||
| visit admin_order_path(payment.order) | ||
|
|
||
| within('table') do |
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Prior to this commit if any routes where omitted for a resource like:
```
resources :users
resources :orders, except: [:edit, :update]
```
Navigating directly to a orders show page would correctly omit the
edit link but if another associated dashboard utilised a field that
rendered using the partial _collection.html.erb like:
```
class UserDashboard < Administrate::BaseDashboard
ATTRIBUTE_TYPES = {
orders: Field::HasMany,
}
SHOW_PAGE_ATTRIBUTES = ATTRIBUTE_TYPES.keys
end
```
when navigating to the users show page an error 500 would be thrown
because the rendering of orders would incorrectly try to link to the
non existent edit route
Fixes #790
|
@karlentwistle very approved! Thank you ❤️ This makes having read-only routes more reliable. |
BenMorganIO
approved these changes
May 12, 2017
|
Thanks! Merging. |
iarie
pushed a commit
to iarie/administrate
that referenced
this pull request
Jun 17, 2017
Prior to this commit if any routes where omitted for a resource like:
```
resources :users
resources :orders, except: [:edit, :update]
```
Navigating directly to a orders show page would correctly omit the
edit link but if another associated dashboard utilised a field that
rendered using the partial _collection.html.erb like:
```
class UserDashboard < Administrate::BaseDashboard
ATTRIBUTE_TYPES = {
orders: Field::HasMany,
}
SHOW_PAGE_ATTRIBUTES = ATTRIBUTE_TYPES.keys
end
```
when navigating to the users show page an error 500 would be thrown
because the rendering of orders would incorrectly try to link to the
non existent edit route
Fixes thoughtbot#790
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit if any routes where omitted for a resource like:
Navigating directly to a orders show page would correctly omit the edit link but if another associated dashboard utilised a field that rendered using the partial
_collection.html.erblike:when navigating to the users show page an error 500 would be thrown because the rendering of orders would incorrectly try to link to the non existent edit route
Fixes #790