Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation navigation #885

Merged
merged 3 commits into from
May 16, 2017
Merged

Update documentation navigation #885

merged 3 commits into from
May 16, 2017

Conversation

odlp
Copy link
Contributor

@odlp odlp commented May 12, 2017

Changes:

  • Add link to Github repo
  • Remove duplicate "README" link (dupe of "Home")
  • Test each navigation link points to a page which exists

Before:

a-before

After:

a-after

def internal_documentation_links
all(".sidebar a").
map{ |anchor| anchor[:href] }.
select{ |href| URI.parse(href).relative? }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space missing to the left of {.


def internal_documentation_links
all(".sidebar a").
map{ |anchor| anchor[:href] }.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space missing to the left of {.

@odlp odlp force-pushed the op-link-docs-github branch from b371e95 to 2fe354c Compare May 12, 2017 16:23
@BenMorganIO BenMorganIO self-requested a review May 12, 2017 18:39
@odlp odlp merged commit f4948bb into master May 16, 2017
@odlp odlp deleted the op-link-docs-github branch May 16, 2017 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants