Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document renaming dashboard #946

Merged
merged 1 commit into from
Jul 28, 2017
Merged

Document renaming dashboard #946

merged 1 commit into from
Jul 28, 2017

Conversation

rozhok
Copy link
Contributor

@rozhok rozhok commented Jul 22, 2017

#938

Add docs of how to i18n dashboard name.

Copy link
Member

@nickcharlton nickcharlton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I made a few notes on the copy, but I like the direction.

@@ -158,6 +158,17 @@ end

[define your own]: /adding_custom_field_types

To change dashboard name in sidebar menu, sub-header and search string simply use default ActiveRecord i18n translations for models:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need some "the"s in the start here:

To change the Dashboard name in the sidebar

And would you mind removing "simply"? Whilst in this case it's true, I like to avoid words in our docs like "simply", "easily", etc as this is often not true for everyone.

Add docs of how to i18n dashboard name.
@rozhok
Copy link
Contributor Author

rozhok commented Jul 27, 2017

Sorry for broken English. Fixed.

@nickcharlton
Copy link
Member

No worries, it always takes a bit to get the wording right. I'm going to merge this now, so thanks!

@nickcharlton nickcharlton merged commit c93dd53 into thoughtbot:master Jul 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants