Show errors when has_many restrict_with_error. #961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vgsantoniazzi
commented
Aug 10, 2017
vgsantoniazzi
commented
- Return full_messages with new line separator
houndci-bot
reviewed
Aug 10, 2017
spec/models/order_spec.rb
Outdated
|
|
||
| order.destroy | ||
|
|
||
| expect(order.errors[:base]).to eq(["Cannot delete record because dependent payments exist"]) |
| if requested_resource.destroy | ||
| flash[:notice] = translate_with_resource("destroy.success") | ||
| else | ||
| flash[:error] = requested_resource.errors.full_messages.join("<br/>").html_safe |
houndci-bot
reviewed
Aug 10, 2017
spec/models/order_spec.rb
Outdated
| order.destroy | ||
|
|
||
| expect(order.errors[:base]).to eq( | ||
| ["Cannot delete record because dependent payments exist"] |
There was a problem hiding this comment.
Put a comma after the last parameter of a multiline method call.
houndci-bot
reviewed
Aug 10, 2017
spec/models/order_spec.rb
Outdated
| order.destroy | ||
|
|
||
| expect(order.errors[:base]).to eq( | ||
| ["Cannot delete record because dependent payments exist"] |
There was a problem hiding this comment.
Put a comma after the last parameter of a multiline method call.
vgsantoniazzi
force-pushed
the
master
branch
2 times, most recently
from
133f77a to
ade6fca
Compare
|
This is looking good! Would you be able to provide a screenshot for when you have multiple errors? From reading the implementation, it looks like it'll add a |
vgsantoniazzi
force-pushed
the
master
branch
from
ade6fca to
d5f32fc
Compare
houndci-bot
reviewed
Feb 25, 2018
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
.rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Na...
.rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Naming .rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout .rubocop.yml: Style/AsciiIdentifiers has the wrong namespace - should be Naming .rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout .rubocop.yml: Style/ExtraSpacing has the wrong namespace - should be Layout .rubocop.yml: Style/FileName has the wrong namespace - should be Naming .rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout .rubocop.yml: Style/MultilineMethodCallIndentation has the wrong namespace - should be Layout .rubocop.yml: Style/PredicateName has the wrong namespace - should be Naming .rubocop.yml: Style/InitialIndentation has the wrong namespace - should be Layout Error: The `Lint/InvalidCharacterLiteral` cop has been removed since it was never being actually triggered. (obsolete configuration found in .rubocop.yml, please update it) The `Style/OpMethod` cop has been renamed and moved to `Naming/BinaryOperatorParameterName`.
houndci-bot
reviewed
Feb 25, 2018
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
.rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Na...
.rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Naming .rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout .rubocop.yml: Style/AsciiIdentifiers has the wrong namespace - should be Naming .rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout .rubocop.yml: Style/ExtraSpacing has the wrong namespace - should be Layout .rubocop.yml: Style/FileName has the wrong namespace - should be Naming .rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout .rubocop.yml: Style/MultilineMethodCallIndentation has the wrong namespace - should be Layout .rubocop.yml: Style/PredicateName has the wrong namespace - should be Naming .rubocop.yml: Style/InitialIndentation has the wrong namespace - should be Layout Error: The `Lint/InvalidCharacterLiteral` cop has been removed since it was never being actually triggered. (obsolete configuration found in .rubocop.yml, please update it) The `Style/OpMethod` cop has been renamed and moved to `Naming/BinaryOperatorParameterName`.
* Return full_messages with new line separator
vgsantoniazzi
force-pushed
the
master
branch
from
d5f32fc to
960313f
Compare
|
|
|
@nickcharlton seems good? |
|
This looks great! I'm going to go ahead and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.