Find routes config #991
Merged
Find routes config #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Sep 30, 2017
|
|
||
| def find_file(file_name) | ||
| file = nil | ||
| Find.find(Rails.root) do |path| |
houndci-bot
reviewed
Oct 1, 2017
rnice01
force-pushed
the
find-routes-config
branch
3 times, most recently
from
07b9ac4 to
7fe7550
Compare
There was a problem hiding this comment.
This is off to a great start!
I've left a few comments, but:
- Do you think you could look into the Hound comments?
- Do you think we need to be testing for any of the other cases which we're protecting against in this PR? I'm thinking of all of the places we branch for special cases, really.
|
Hi @rnice01! Sorry, it's been a while. I just answered your question left above. Do you think you'd be able to rebase against current master and fix up the remaining comments? |
|
@rnice01, is this a change you still want to make? |
|
@purinkle, yeah I can get it cleaned up. |
nickcharlton
force-pushed
the
find-routes-config
branch
from
7fe7550 to
0f5d8ae
Compare
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| @@ -4,10 +4,29 @@ def call_generator(generator, *args) | |||
| Rails::Generators.invoke(generator, args, generator_options) | |||
| end | |||
|
|
|||
| def find_routes_file | |||
| routes_file = Rails.root.join("config/routes.rb") | |||
There was a problem hiding this comment.
Rails/FilePath: Please use Rails.root.join('path', 'to') instead.
nickcharlton
force-pushed
the
find-routes-config
branch
from
0f5d8ae to
cf109b2
Compare
nickcharlton
added
feature
Because there may be Rails projects with the routes.rb file in a different location than Rails.root/config a helper was added to locate the file. The helper will look in the 'normal' routes.rb location and then search through the project if not located there.
nickcharlton
force-pushed
the
find-routes-config
branch
from
cf109b2 to
09ef652
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for issue #720 : Both the Install and Routes generators were looking for the project's routes.rb file in /config from the Rail's root path. Which the helper method I added will look for first, if it cannot find the routes.rb file there, then it will search through the project until it finds the path for that file.