Order attributes by association if it exists #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Oct 8, 2017
rnice01
force-pushed
the
scope-sort-to-association
branch
2 times, most recently
from
e9b9f98 to
72a5bd6
Compare
houndci-bot
reviewed
Oct 8, 2017
| relation. | ||
| left_joins(attribute.to_sym). | ||
| group(:id). | ||
| reorder("COUNT(#{attribute}.id) #{direction}") |
There was a problem hiding this comment.
Use 2 (not 0) spaces for indenting an expression spanning multiple lines.
| def order_by_count(relation) | ||
| relation. | ||
| left_joins(attribute.to_sym). | ||
| group(:id). |
There was a problem hiding this comment.
Use 2 (not 0) spaces for indenting an expression spanning multiple lines.
|
|
||
| def order_by_count(relation) | ||
| relation. | ||
| left_joins(attribute.to_sym). |
There was a problem hiding this comment.
Use 2 (not 0) spaces for indenting an expression spanning multiple lines.
rnice01
force-pushed
the
scope-sort-to-association
branch
from
72a5bd6 to
5054c7e
Compare
|
I'm not sure if I have completely missed the mark or not with these changes for #471 would love some feedback so I can make changes as needed and add specs as well. |
|
@nickcharlton |
houndci-bot
reviewed
Oct 22, 2017
rnice01
force-pushed
the
scope-sort-to-association
branch
from
f5e3066 to
dadf9f2
Compare
houndci-bot
reviewed
Oct 28, 2017
houndci-bot
reviewed
Oct 28, 2017
houndci-bot
reviewed
Oct 28, 2017
houndci-bot
reviewed
Oct 28, 2017
houndci-bot
reviewed
Dec 12, 2017
houndci-bot
reviewed
Dec 12, 2017
Adding an order clause to the relation for an associated
attribute was having no effect on the dashboard's sorting.
When the order is applied, the current relation will check
if the attribute is an association and reorder by count
on the attribute's id column or on the relation's
{attribute}_id column following the Rails convention
of naming FK columns. The relation order method was
changed to reorder to override any default scoping
that may exist for the relation.
thoughtbot#471
rnice01
force-pushed
the
scope-sort-to-association
branch
from
46f160b to
564a86e
Compare
|
Thanks! I'm going to merge this as the two CI failures are around elsewhere, too. |
|
Awesome, thanks for all the help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an order clause to the relation for an associated attribute was having no effect on the dashboard's sorting. When the order is applied, the current relation will check if the attribute is an association and reorder by count on the attribute's id column or on the relation's {attribute}_id column following the Rails convention of naming FK columns. The relation order method was changed to reorder to override any default scoping that may exist for the relation.
#471