This repository has been archived by the owner on Sep 13, 2024. It is now read-only.
Suppress deprecation warnings when called from bourbon #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tysongach
suggested changes
Feb 7, 2017
| @@ -22,5 +22,8 @@ | |||
| /// @output `border-color` | |||
|
|
|||
| @mixin border-color($vals...) { | |||
| $deprecation-warnings: $output-bourbon-deprecation-warnings; | |||
There was a problem hiding this comment.
For clarity, what about renaming this from $deprecation-warnings to $user-setting-for-deprecation-warnings?
There was a problem hiding this comment.
Maybe just $user-deprecation-warnings-setting? Bit shorter.
tysongach
approved these changes
Feb 8, 2017
|
Thanks, @CupOfTea696! Merged as 14ee63f. |
|
We just released v4.3.1 which includes these changes. |
|
@tysongach You're welcome, and awesome that it's released! |
|
@tysongach to not spam #702 I'm confirming that this is related to issues I'm seeing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Suppresses deprecation warnings when deprecated functions or mixins from other bourbon functions or mixins. This will stop a lot of confusion when people suddenly see loads of deprecation warnings for functions or mixins they didn't use directly.
If this is related to an existing issue, include a link to it as well.
Solves: #1001