Fail the process if exec fails
#236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -339,7 +339,7 @@ def env_hash | |||
|
|
|||
| def exec(cmd, method: :system) | |||
| Dir.chdir root do | |||
| Kernel.public_send(method, env_hash, cmd, err: :out) | |||
| Kernel.public_send(method, env_hash, cmd, err: :out) or fail(cmd) | |||
There was a problem hiding this comment.
I think you might also be able to use Kernel.exit here: https://github.com/thoughtbot/parity/blob/256f9a3f995d21fa6059efcd523855f2a1a0c381/bin/production#L8
There was a problem hiding this comment.
@geoffharcourt yup, ended up using that here
seanpdoyle
force-pushed
the
sd-fail-with-non-zero-exit-status
branch
from
9ba5b36
to
b8b8963
Compare
|
This slipped my mind before, but is there a way to test this by simulating the failure of a dependency build? |
|
@geoffharcourt do you mean in a test? |
|
Yeah. Unfortunately we didn't do it in Parity on the same type of change, so maybe that's overkill. |
seanpdoyle
force-pushed
the
sd-fail-with-non-zero-exit-status
branch
2 times, most recently
from
5e6d461
to
dd68cd0
Compare
When running `install_dependencies` or `compile`, failures won't halt the host program. This could lead to false positives and difficult to debug scenarios. Consumers would prefer this to fail as early on as possible.
seanpdoyle
force-pushed
the
sd-fail-with-non-zero-exit-status
branch
from
dd68cd0
to
afa84fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
install_dependenciesorcompile, failures won't haltthe host program.
This could lead to false positives and difficult to debug scenarios.
Consumers would prefer this to fail as early on as possible.