Skip to content

Commit

Permalink
Exit with status 1 the process if exec fails
Browse files Browse the repository at this point in the history
When running `install_dependencies` or `compile`, failures won't halt
the host program.

This could lead to false positives and difficult to debug scenarios.

Consumers would prefer this to fail as early on as possible.
  • Loading branch information
seanpdoyle committed Nov 3, 2015
1 parent ef0fc67 commit b8b8963
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/ember-cli/app.rb
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,7 @@ def env_hash

def exec(cmd, method: :system)
Dir.chdir root do
Kernel.public_send(method, env_hash, cmd, err: :out)
Kernel.public_send(method, env_hash, cmd, err: :out) || exit(1)
end
end

Expand Down

0 comments on commit b8b8963

Please sign in to comment.