Build Error includes first line of backtrace #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| error.set_backtrace build_error_file_path.readlines | ||
| backtrace = build_error_file_path.readlines.reject(&:blank?) | ||
|
|
||
| error = BuildError.new("#{name.inspect} has failed to build: #{backtrace.first}") |
seanpdoyle
force-pushed
the
sd-format-error-backtrace
branch
from
0ba2399
to
cc46975
Compare
[rails/web-console] is meant to display Ruby errors. When presented with JS stack traces, or free text CLI error messages, it confusingly displays a large (almost to the fold) white console box. To make it more obvious what the client-side error was, we include the first line of the backtrace in the `BuildError`'s message. [rails/web-console]: https://github.com/rails/web-console
seanpdoyle
force-pushed
the
sd-format-error-backtrace
branch
from
cc46975
to
ddb11f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rails/web-console is meant to display Ruby errors.
When presented with JS stack traces, or free text CLI error messages, it
confusingly displays a large (almost to the fold) white console box.
To make it more obvious what the client-side error was, we include the
first line of the backtrace in the
BuildError's message.