Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add standard settings #1625

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Conversation

ydah
Copy link
Contributor

@ydah ydah commented Feb 19, 2024

The following settings have been added.

  • Set parallel execution to true
  • Change format to progress

The following settings have been added.
* Set parallel execution to true
* Change format to progress
@ydah ydah requested a review from mike-burns as a code owner February 19, 2024 14:23
@mike-burns
Copy link
Contributor

Documentation

  • parallel passes down to Rubocop, and it does this:

    Use available CPUs to execute inspection in parallel.

  • progress also passes down to Rubocop, and prints a . for each clean file.

Both of these are the Rubocop defaults. Standard overrides the defaults:

  • parallel interacts poorly with stdin mode. As such, it is forcibly overridden in stdin mode, and the default is not to use it.
  • progress doesn't mention standard, which seems to be why the Standard::Formatter was introduced.

Analysis

I don't even use Standard, but it runs as part of CI. Sure, I'll merge these changes, and if someone complains I'll back them out.

@mike-burns mike-burns merged commit 43dd9da into thoughtbot:main Feb 19, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants