Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the minimum version of sqlite3 #1667

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update the minimum version of sqlite3
This project currently uses `sqlite3` version `1.4.2` which was released
on 18 December 2019. The latest version of `sqlite3` currently available
is `2.0.2` which was released on 23 May 2024.

This commit updates the minimum version of `sqlite3` to version `1.5.0`
that is readily able to compile on a M1 chip.
  • Loading branch information
smaboshe committed Jun 21, 2024
commit 1aca56954a91a29c5bfec12ad8c6ff78d2666cae
8 changes: 4 additions & 4 deletions Appraisals
Original file line number Diff line number Diff line change
@@ -1,25 +1,25 @@
appraise "6.1" do
gem "activerecord", "~> 6.1.0"
gem "activerecord-jdbcsqlite3-adapter", "~> 61.0", platforms: [:jruby]
gem "sqlite3", platforms: [:ruby]
gem "sqlite3", "> 1.6.9", platforms: [:ruby]
end

appraise "7.0" do
gem "activerecord", "~> 7.0.0"
gem "activerecord-jdbcsqlite3-adapter", "~> 70.0", platforms: [:jruby]
gem "sqlite3", platforms: [:ruby]
gem "sqlite3", "> 1.6.9", platforms: [:ruby]
end

appraise "7.1" do
gem "activerecord", "~> 7.1.0"
# When version 71 is released, uncomment this and also allow it in the GitHub
# Action build workflow.
# gem "activerecord-jdbcsqlite3-adapter", "~> 71.0", platforms: [:jruby]
gem "sqlite3", platforms: [:ruby]
gem "sqlite3", "> 1.6.9", platforms: [:ruby]
end

appraise "main" do
gem "activerecord", git: "https://github.com/rails/rails.git", branch: "main"
gem "activerecord-jdbcsqlite3-adapter", "~> 70.0", platforms: [:jruby]
gem "sqlite3", platforms: [:ruby]
gem "sqlite3", "> 1.6.9", platforms: [:ruby]
end
4 changes: 3 additions & 1 deletion Gemfile.lock
Original file line number Diff line number Diff line change
@@ -73,6 +73,7 @@ GEM
language_server-protocol (3.17.0.3)
lint_roller (1.1.0)
middleware (0.1.0)
mini_portile2 (2.8.7)
minitest (5.14.3)
multi_test (0.1.2)
parallel (1.24.0)
@@ -128,7 +129,8 @@ GEM
simplecov_json_formatter (~> 0.1)
simplecov-html (0.12.3)
simplecov_json_formatter (0.1.2)
sqlite3 (1.4.2)
sqlite3 (2.0.2)
mini_portile2 (~> 2.8.0)
standard (1.34.0)
language_server-protocol (~> 3.17.0.2)
lint_roller (~> 1.0)
2 changes: 1 addition & 1 deletion gemfiles/6.1.gemfile
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@
source "https://rubygems.org"

gem "activerecord-jdbcsqlite3-adapter", "~> 61.0", platforms: [:jruby]
gem "sqlite3", platforms: [:ruby]
gem "sqlite3", "> 1.6.9", platforms: [:ruby]
gem "activerecord", "~> 6.1.0"

gemspec name: "factory_bot", path: "../"
6 changes: 4 additions & 2 deletions gemfiles/6.1.gemfile.lock
Original file line number Diff line number Diff line change
@@ -70,6 +70,7 @@ GEM
i18n (1.8.9)
concurrent-ruby (~> 1.0)
middleware (0.1.0)
mini_portile2 (2.8.7)
minitest (5.14.3)
multi_test (0.1.2)
parallel (1.20.1)
@@ -121,7 +122,8 @@ GEM
simplecov_json_formatter (~> 0.1)
simplecov-html (0.12.3)
simplecov_json_formatter (0.1.2)
sqlite3 (1.4.2)
sqlite3 (1.7.3)
mini_portile2 (~> 2.8.0)
standard (0.13.0)
rubocop (= 1.10.0)
rubocop-performance (= 1.9.2)
@@ -149,7 +151,7 @@ DEPENDENCIES
rspec
rspec-its
simplecov
sqlite3
sqlite3 (> 1.6.9)
standard
yard

2 changes: 1 addition & 1 deletion gemfiles/7.0.gemfile
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@
source "https://rubygems.org"

gem "activerecord-jdbcsqlite3-adapter", "~> 70.0", platforms: [:jruby]
gem "sqlite3", platforms: [:ruby]
gem "sqlite3", "> 1.6.9", platforms: [:ruby]
gem "activerecord", "~> 7.0.0"

gemspec name: "factory_bot", path: "../"
6 changes: 4 additions & 2 deletions gemfiles/7.0.gemfile.lock
Original file line number Diff line number Diff line change
@@ -117,7 +117,8 @@ GEM
simplecov_json_formatter (~> 0.1)
simplecov-html (0.12.3)
simplecov_json_formatter (0.1.4)
sqlite3 (1.6.3-x86_64-linux)
sqlite3 (1.7.3-arm64-darwin)
sqlite3 (1.7.3-x86_64-linux)
standard (1.29.0)
language_server-protocol (~> 3.17.0.2)
lint_roller (~> 1.0)
@@ -140,6 +141,7 @@ GEM
webrick (~> 1.7.0)

PLATFORMS
arm64-darwin-23
x86_64-linux

DEPENDENCIES
@@ -153,7 +155,7 @@ DEPENDENCIES
rspec
rspec-its
simplecov
sqlite3
sqlite3 (> 1.6.9)
standard
yard

2 changes: 1 addition & 1 deletion gemfiles/7.1.gemfile
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@
source "https://rubygems.org"

gem "activerecord-jdbcsqlite3-adapter", platforms: [:jruby]
gem "sqlite3", platforms: [:ruby]
gem "sqlite3", "> 1.6.9", platforms: [:ruby]
gem "activerecord", "~> 7.1.0"

gemspec name: "factory_bot", path: "../"
4 changes: 3 additions & 1 deletion gemfiles/7.1.gemfile.lock
Original file line number Diff line number Diff line change
@@ -127,6 +127,7 @@ GEM
simplecov_json_formatter (~> 0.1)
simplecov-html (0.12.3)
simplecov_json_formatter (0.1.4)
sqlite3 (1.7.0-arm64-darwin)
sqlite3 (1.7.0-x86_64-linux)
standard (1.32.1)
language_server-protocol (~> 3.17.0.2)
@@ -150,6 +151,7 @@ GEM
yard (0.9.34)

PLATFORMS
arm64-darwin-23
x86_64-linux

DEPENDENCIES
@@ -163,7 +165,7 @@ DEPENDENCIES
rspec
rspec-its
simplecov
sqlite3
sqlite3 (> 1.6.9)
standard
yard

2 changes: 1 addition & 1 deletion gemfiles/main.gemfile
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@
source "https://rubygems.org"

gem "activerecord-jdbcsqlite3-adapter", "~> 70.0", platforms: [:jruby]
gem "sqlite3", platforms: [:ruby]
gem "sqlite3", "> 1.6.9", platforms: [:ruby]
gem "activerecord", git: "https://github.com/rails/rails.git", branch: "main"

gemspec name: "factory_bot", path: "../"
7 changes: 4 additions & 3 deletions gemfiles/main.gemfile.lock
Original file line number Diff line number Diff line change
@@ -80,7 +80,7 @@ GEM
language_server-protocol (3.17.0.3)
lint_roller (1.1.0)
mini_mime (1.1.5)
mini_portile2 (2.8.5)
mini_portile2 (2.8.7)
minitest (5.20.0)
multi_test (1.1.0)
parallel (1.23.0)
@@ -132,8 +132,9 @@ GEM
simplecov_json_formatter (~> 0.1)
simplecov-html (0.12.3)
simplecov_json_formatter (0.1.4)
sqlite3 (1.6.9)
sqlite3 (1.7.3)
mini_portile2 (~> 2.8.0)
sqlite3 (1.7.3-x86_64-linux)
standard (1.32.1)
language_server-protocol (~> 3.17.0.2)
lint_roller (~> 1.0)
@@ -170,7 +171,7 @@ DEPENDENCIES
rspec
rspec-its
simplecov
sqlite3
sqlite3 (> 1.6.9)
standard
yard