Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use factory_bot , ~> 6.3 #423

Closed
wants to merge 1 commit into from
Closed

Use factory_bot , ~> 6.3 #423

wants to merge 1 commit into from

Conversation

ydah
Copy link
Contributor

@ydah ydah commented Sep 3, 2023

This PR bump factory_bot to 6.3.

@dan-manges
Copy link

If factory_bot follows semver, should it be safe to change this to ~> 6.3 to only pin to the major version? Or does factory_bot_rails want to stay in sync with factory_bot by matching the minor version?

@ansonhoyt
Copy link

@ydah I noticed this has been bumped with #419

@@ -14,6 +14,6 @@ Gem::Specification.new do |s|
s.executables = []
s.license = "MIT"

s.add_runtime_dependency("factory_bot", "~> 6.2.0")
s.add_runtime_dependency("factory_bot", "~> 6.3.0")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~> 6.2 sounds better to me

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated this PR.

@ydah ydah changed the title Bump factory_bot , ~> 6.3.0 Use factory_bot , ~> 6.3 Oct 18, 2023
@ydah ydah closed this Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants