Wrap ActiveRecord configuration into initializer #432

leoarnold · 2023-11-17T20:55:34Z

Rails.application is not available when the railties are collected, so we move the ActiveRecord configuration into the initializer phase.

NoMethodError: undefined method `config' for nil:NilClass (NoMethodError)
      application.config
                 ^^^^^^^
/project/app/vendor/bundle/ruby/3.2.0/gems/railties-7.0.8/lib/rails.rb:47:in `configuration'
/project/app/vendor/bundle/ruby/3.2.0/gems/factory_bot_rails-6.4.0/lib/factory_bot_rails/railtie.rb:25:in `block in <class:Railtie>'

`Rails.application` is not available when the railties are collected, so we move the ActiveRecord configuration into the initializer phase. ``` NoMethodError: undefined method `config' for nil:NilClass (NoMethodError) application.config ^^^^^^^ /project/app/vendor/bundle/ruby/3.2.0/gems/railties-7.0.8/lib/rails.rb:47:in `configuration' /project/app/vendor/bundle/ruby/3.2.0/gems/factory_bot_rails-6.4.0/lib/factory_bot_rails/railtie.rb:25:in `block in <class:Railtie>' ```

f-asa · 2023-11-17T21:55:11Z

APPROUVED

tagliala · 2023-11-17T22:29:55Z

This should fix #426

…gets merged and released as a gem

Lock factory_bot_rails to 6.2.x until thoughtbot/factory_bot_rails#432 gets merged and released as a gem

williamromero

This solution using lazy load hook "initializer" is solving the issue.

lib/factory_bot_rails/railtie.rb

simi

I can confirm this fixes #426 issue.

torrocus · 2023-11-20T16:19:15Z

I can also confirm that this fixes #426 & #433 issues.

TylerRick · 2023-11-21T00:14:41Z

I just ran into this as well after a bundle update, and ended up pushing a similar PR, #435, before I saw this one.

This looks good! Merge please?

LeFnord · 2023-11-21T09:43:35Z

thanks, works perfectly well … any plans to merge and release it?

jrochkind · 2023-11-21T15:50:41Z

This bug is making CI builds across the planet fail, a quick release would be great.

I'm curious how the original bug passed factory_bot_rails's own CI build, and wonder if there's a test that could have caught the bug, that should be added.

JDutil · 2023-11-21T17:46:35Z

This resolves the issue for me as well.

There's a bug in the latest version of `factory_bot_rails`: thoughtbot/factory_bot_rails#433 There's also a fix that hasn't been merged or released yet: thoughtbot/factory_bot_rails#432 I'm setting the `Gemfile` to specifically avoid those buggy versions so that we can get `depfu` un-blocked with keeping gems up to date.

* Avoid buggy versions of factory_bot_rails There's a bug in the latest version of `factory_bot_rails`: thoughtbot/factory_bot_rails#433 There's also a fix that hasn't been merged or released yet: thoughtbot/factory_bot_rails#432 I'm setting the `Gemfile` to specifically avoid those buggy versions so that we can get `depfu` un-blocked with keeping gems up to date. * dang linter

joseluistorres

🚀

mobilutz · 2023-11-22T09:44:19Z

I would like to see this shipped.

And as @jrochkind said

I'm curious how the original bug passed factory_bot_rails's own CI build, and wonder if there's a test that could have caught the bug, that should be added.

Thanks

mike-burns · 2023-11-22T14:14:24Z

Hi, thanks for tracking this down. I cannot work on this bug this week, but I do I have time to merge PRs and cut releases.

If someone could add a test to this, that'd be the last step we need. Thank you!

This is well known issue. We should prefer to code that reference active record only when it's already lazy loaded. It can break other gems initializing process Related: - rails/rails#46567 - paper-trail-gem/paper_trail@fc6c5f6 (inspiration) - thoughtbot/factory_bot_rails#432 Fix: DatabaseCleaner#89

benoittgt · 2023-11-23T11:59:12Z

I cherry picked this commit and added a non-regression test. I also make sure we are good on Rails 7.1 too.

#440

makicamel

@leoarnold
Thank you for your PR!
This diff (test codes) might help to merge this PR (ref #432 (comment)):

--- a/spec/spec_helper.rb
+++ b/spec/spec_helper.rb
@@ -2,6 +2,10 @@

 ENV["RAILS_ENV"] = "test"

+require "active_record"
+
+class ActiveRecord::Base; end
+
 require "factory_bot_rails"
 require "fake_app"

There are gem monkey-patched to ActiveRecord. With these, ActiveRecord might be loaded before Rails.application is initialized. This is the cause of #426 .
This code snippet reproduces ActiveRecord being loaded before Rails.application is initialized.

lib/factory_bot_rails/railtie.rb

julienchabanon mentioned this pull request Nov 17, 2023

undefined method `config' for nil:NilClass after upgrading to 6.4.0 #433

Closed

Arie added a commit to Arie/serveme that referenced this pull request Nov 18, 2023

Lock factory_bot_rails to 6.2.x until thoughtbot/factory_bot_rails#432 …

25aae07

…gets merged and released as a gem

Arie added a commit to Arie/serveme that referenced this pull request Nov 18, 2023

Gem updates

254dff1

Lock factory_bot_rails to 6.2.x until thoughtbot/factory_bot_rails#432 gets merged and released as a gem

tagliala mentioned this pull request Nov 18, 2023

The railtie included in #419 breaks compatibility with some gems "undefined method `config' for nil:NilClass" Factory Bot > 6.2.0 #426

Closed

3 tasks

williamromero approved these changes Nov 20, 2023

View reviewed changes

lib/factory_bot_rails/railtie.rb Show resolved Hide resolved

patrick-laa mentioned this pull request Nov 20, 2023

Bump factory_bot_rails from 6.2.0 to 6.4.0 ministryofjustice/laa-check-client-qualifies#1109

Closed

simi approved these changes Nov 20, 2023

View reviewed changes

tagliala mentioned this pull request Nov 20, 2023

Issue with the upcoming Factory Bot Rails due to lacking of lazy load hooks DatabaseCleaner/database_cleaner-active_record#89

Closed

torrocus mentioned this pull request Nov 20, 2023

Revert "Bump factory_bot_rails from 6.2.0 to 6.4.0" fractalsoft/fractalsoft.org#437

Merged

jagthedrummer mentioned this pull request Nov 20, 2023

[ruby] Update all Bundler dependencies (2023-11-21) bullet-train-co/bullet_train#1167

Merged

TylerRick mentioned this pull request Nov 21, 2023

Change from on_load :active_record to on_load :after_initialize to ensure the Rails configuration is available #435

Closed

jagthedrummer mentioned this pull request Nov 21, 2023

Avoid buggy versions of factory_bot_rails bullet-train-co/bullet_train#1173

Merged

joseluistorres approved these changes Nov 21, 2023

View reviewed changes

just1602 mentioned this pull request Nov 22, 2023

Build(deps-dev): Bump the bundler-dev group with 2 updates crimethinc/website#3706

Closed

danidoni mentioned this pull request Nov 22, 2023

Update factory_bot 6.2.1 → 6.4.1 (minor) SUSE/hackweek#1399

Closed

gclssvglx mentioned this pull request Nov 22, 2023

Bump factory_bot_rails from 6.2.0 to 6.4.0 alphagov/search-admin#1075

Closed

freesteph mentioned this pull request Nov 22, 2023

gem: updates betagouv/aplypro#186

Merged

simi mentioned this pull request Nov 22, 2023

Bump factory_bot_rails from 6.2.0 to 6.4.0 rubygems/rubygems.org#4216

Merged

rnestler mentioned this pull request Nov 23, 2023

Fix/rails 7.1.2 compatibility #436

Closed

adifsgaid mentioned this pull request Nov 23, 2023

Leoarnold/activerecord on load #439

Closed

This was referenced Nov 23, 2023

Defer code loading when active record is properly loaded DatabaseCleaner/database_cleaner-active_record#90

Closed

Fix undefined method config #440

Merged

makicamel reviewed Nov 23, 2023

View reviewed changes

lib/factory_bot_rails/railtie.rb Show resolved Hide resolved

neilvcarvalho closed this in #440 Nov 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Wrap ActiveRecord configuration into initializer #432

Wrap ActiveRecord configuration into initializer #432

leoarnold commented Nov 17, 2023

f-asa commented Nov 17, 2023

tagliala commented Nov 17, 2023

williamromero left a comment

simi left a comment

torrocus commented Nov 20, 2023 •

edited

Loading

TylerRick commented Nov 21, 2023

LeFnord commented Nov 21, 2023

jrochkind commented Nov 21, 2023

JDutil commented Nov 21, 2023

joseluistorres left a comment

mobilutz commented Nov 22, 2023

mike-burns commented Nov 22, 2023

benoittgt commented Nov 23, 2023

makicamel left a comment •

edited

Loading

Wrap ActiveRecord configuration into initializer #432

Wrap ActiveRecord configuration into initializer #432

Conversation

leoarnold commented Nov 17, 2023

f-asa commented Nov 17, 2023

tagliala commented Nov 17, 2023

williamromero left a comment

Choose a reason for hiding this comment

simi left a comment

Choose a reason for hiding this comment

torrocus commented Nov 20, 2023 • edited Loading

TylerRick commented Nov 21, 2023

LeFnord commented Nov 21, 2023

jrochkind commented Nov 21, 2023

JDutil commented Nov 21, 2023

joseluistorres left a comment

Choose a reason for hiding this comment

mobilutz commented Nov 22, 2023

mike-burns commented Nov 22, 2023

benoittgt commented Nov 23, 2023

makicamel left a comment • edited Loading

Choose a reason for hiding this comment

torrocus commented Nov 20, 2023 •

edited

Loading

makicamel left a comment •

edited

Loading