Skip to content
This repository has been archived by the owner on Jul 14, 2023. It is now read-only.

Fixing unescaped multiline string. #620

Closed
wants to merge 1 commit into from
Closed

Fixing unescaped multiline string. #620

wants to merge 1 commit into from

Conversation

sixtyfive
Copy link
Contributor

@sixtyfive sixtyfive commented Jul 4, 2017

Just getting rid of the deprecation message as it's been getting on my nerves.

Related to:

  • Commit message has a short title & issue references
    (Sorry, couldn't find an issue about this)

  • Commits are squashed
    (There is only one)

  • The build will pass (run bundle exec rake).

@@ -19,7 +19,7 @@

@mixin grid-container($grid: $neat-grid) {
@if $grid != $neat-grid {
@warn "`grid-container` does not use grid properties.
@warn "`grid-container` does not use grid properties. \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the sake of consistency, can we mimic how Bourbon does it and use two strings concatenated together with a +? Also, lining up Line 23 to 22 based on the first quotation marks?

@sixtyfive
Copy link
Contributor Author

I implemented the changes per your wishes but didn't manage to successfully squash the two commits together (it was my first time to try and do so). I hope the fact that there's a merge now isn't too troublesome...

@tysongach
Copy link
Contributor

@sixtyfive Try this:

git rebase -i HEAD~3

You’re editor should open, and you’ll see the three commits you’ve made with pick at the front of each line, for example:

pick bde6957 Fixing unescaped multiline string.
pick 9abc2cb Fixing unescaped multiline string.
pick c02a8e3 Merge branch 'master' of github.com:sixtyfive/neat

Change the last two picks to fixup, and save and close that file. That should leave you with one commit, the original, with the two later commits squashed into it. Then you can force push (git push --force) back up to GitHub.

@sixtyfive
Copy link
Contributor Author

image

Not so, unfortunately :-(
(Basically the same thing that happened the first time I tried the rebase -i...)

@sixtyfive
Copy link
Contributor Author

Tried to follow those instructions, ended up with another merge commit again. Sniff.

# This is the 1st commit message:

# This is a combination of 2 commits.
# This is the 1st commit message:

fix typo
# The commit message #2 will be skipped:

# Fixing unescaped multiline string.
#
# - sass/sass#1302
# - sass/sass#1237
# - sass/libsass#942
#
# Changing to adhere to Bourbon style.

# The commit message #2 will be skipped:

# Fixing unescaped multiline string.
#
# - sass/sass#1302
# - sass/sass#1237
# - sass/libsass#942
#
# Changing to adhere to Bourbon style.
@sixtyfive
Copy link
Contributor Author

@tysongach I think I'm making it worse. Right now it looks as if you probably just need to press a button behind "Resolve conflicts" so I'll leave it at this for now unless you have any instructions for what I should further do. Sorry for the hullabaloo.

@tysongach
Copy link
Contributor

Ah, looks like you accidentally combined your commit with 2bde983 on master. No worries, I’ll get it fixed up for you and merged.

@tysongach
Copy link
Contributor

Merged as 8bbdd4d.

@tysongach tysongach closed this Jul 5, 2017
@sixtyfive
Copy link
Contributor Author

Thank you much! At least I learned that after a rebase you must push -f. Next time it'll hopefully work out fine.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants