-
-
Notifications
You must be signed in to change notification settings - Fork 424
Conversation
@@ -19,7 +19,7 @@ | |||
|
|||
@mixin grid-container($grid: $neat-grid) { | |||
@if $grid != $neat-grid { | |||
@warn "`grid-container` does not use grid properties. | |||
@warn "`grid-container` does not use grid properties. \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the sake of consistency, can we mimic how Bourbon does it and use two strings concatenated together with a +
? Also, lining up Line 23 to 22 based on the first quotation marks?
I implemented the changes per your wishes but didn't manage to successfully squash the two commits together (it was my first time to try and do so). I hope the fact that there's a merge now isn't too troublesome... |
@sixtyfive Try this:
You’re editor should open, and you’ll see the three commits you’ve made with
Change the last two |
Tried to follow those instructions, ended up with another merge commit again. Sniff. |
# This is the 1st commit message: # This is a combination of 2 commits. # This is the 1st commit message: fix typo # The commit message #2 will be skipped: # Fixing unescaped multiline string. # # - sass/sass#1302 # - sass/sass#1237 # - sass/libsass#942 # # Changing to adhere to Bourbon style. # The commit message #2 will be skipped: # Fixing unescaped multiline string. # # - sass/sass#1302 # - sass/sass#1237 # - sass/libsass#942 # # Changing to adhere to Bourbon style.
@tysongach I think I'm making it worse. Right now it looks as if you probably just need to press a button behind "Resolve conflicts" so I'll leave it at this for now unless you have any instructions for what I should further do. Sorry for the hullabaloo. |
Ah, looks like you accidentally combined your commit with 2bde983 on |
Merged as 8bbdd4d. |
Thank you much! At least I learned that after a |
Just getting rid of the deprecation message as it's been getting on my nerves.
Related to:
Commit message has a short title & issue references
(Sorry, couldn't find an issue about this)
Commits are squashed
(There is only one)
The build will pass (run
bundle exec rake
).