This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
Saving images from url with special characters #1921 #1932
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end | ||
|
|
||
| it "returns a file name" do | ||
| assert_equal "paperclip-%C3%B6%C3%A4%C3%BC%E5%AD%97%C2%B4%C2%BD%E2%99%A5%C3%98%C2%B2%C3%88.png", @subject.original_filename |
|
One quick comment, and if you can handle the Hound complaints, I'll totally pull this in. Thanks! |
| url = "https://github.com/thoughtbot/paperclip-öäü字´½♥زÈ.png" | ||
| subject = Paperclip.io_adapters.for(url) | ||
| filename = 'paperclip-%C3%B6%C3%A4%C3%BC%E5%AD%97%C2%B4%C2%BD%E2%99%A5'\ | ||
| '%C3%98%C2%B2%C3%88.png' |
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
|
@jyurek I don't get this errors on my local machine. |
|
Why is this not merged? Having the same problems with UTF-8 characters in the URI (e.g. |
|
Thanks for your work! @Piioo, can you please squash your commits together and rebase on top of latest master? If CI is green, we'll merge. Thanks! ❤️ |
|
I've got a passing CI build, will rebase myself: https://travis-ci.org/thoughtbot/paperclip/builds/128930480. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1921 Now it is possible to save images from url with special characters like http://www.foo/öäü.jpg