This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
[backport] The uri io adapter should use the content-disposition filename #2250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| context "a url with restricted characters in the filename" do | ||
| before do | ||
| Paperclip::UriAdapter.any_instance.stubs(:download_content).returns(StringIO.new("xxx")) | ||
| Paperclip::UriAdapter.any_instance. | ||
| stubs(:download_content).returns(@open_return) |
There was a problem hiding this comment.
Use 2 (not 4) spaces for indenting an expression spanning multiple lines.
- The uri io adapter now seeks for the content-disposition header if this is pressent the value filename is taken instead of the last path segment for the resource file name - Fix style comments - Applied the Tute Costa refactor to URI Adapter. - Added entry to the NEWS file. - Removed editor tracking file - Fix test cases
netmask
force-pushed
the
port/uri_adapter_use_content_disposition
branch
from
5077e20 to
a008c68
Compare
|
Thank you very much! 👏 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tute port from #2210
if this is pressent the value filename is taken instead of the
last path segment for the resource file name