This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
Support s3 host alias with prefixes #2287
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| context "generating a url with a prefixed host alias" do | ||
| before do | ||
| rebuild_model( | ||
| aws2_add_region.merge storage: :s3, |
There was a problem hiding this comment.
Add parentheses to nested method call aws2_add_region.merge storage: :s3, s3_credentials: { production: { bucket: "prod_bucket" }, development: { bucket: "dev_bucket" }, }, bucket: "bucket", s3_host_alias: "something.something.com", s3_prefixes_in_alias: 2, path: "prefix1/prefix2/:attachment/:basename:dotextension", url: ":s3_alias_url".
|
Thanks! Can you please rebase against latest master, and address Hound comments? Thanks! |
| protocol = attachment.s3_protocol(style, true) | ||
| host = attachment.s3_host_alias | ||
| path = attachment.path(style). | ||
| split("/")[attachment.s3_prefixes_in_alias..-1]. |
There was a problem hiding this comment.
Use 2 (not 7) spaces for indenting an expression in an assignment spanning multiple lines.
|
Merged into master. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows s3_host_alias to be set to CDNs which support S3 Bucket prefix