This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
Add migration_version variable to migration generator for rails 5 compatibility #2470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jul 18, 2017
| @@ -27,4 +27,10 @@ def migration_file_name | |||
| def migration_class_name | |||
| migration_name.camelize | |||
| end | |||
|
|
|||
| def migration_version | |||
| if Rails.version.start_with? '5' | |||
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
| @@ -13,7 +13,7 @@ def self.source_root | |||
| end | |||
|
|
|||
| def generate_migration | |||
| migration_template "paperclip_migration.rb.erb", "db/migrate/#{migration_file_name}" | |||
| migration_template "paperclip_migration.rb.erb", "db/migrate/#{migration_file_name}", migration_version: migration_version | |||
houndci-bot
reviewed
Jul 18, 2017
| migration_template("paperclip_migration.rb.erb", | ||
| "db/migrate/#{migration_file_name}", | ||
| migration_version: migration_version | ||
| ) |
There was a problem hiding this comment.
Closing method call brace must be on the same line as the last argument when opening brace is on the same line as the first argument.
| migration_template "paperclip_migration.rb.erb", "db/migrate/#{migration_file_name}" | ||
| migration_template("paperclip_migration.rb.erb", | ||
| "db/migrate/#{migration_file_name}", | ||
| migration_version: migration_version |
There was a problem hiding this comment.
Put a comma after the last parameter of a multiline method call.
|
This looks like a great solution. What is stopping this from being merged? |
Fernan2
reviewed
Aug 4, 2017
| @@ -27,4 +29,10 @@ def migration_file_name | |||
| def migration_class_name | |||
| migration_name.camelize | |||
| end | |||
|
|
|||
| def migration_version | |||
| if Rails.version.start_with? "5" | |||
There was a problem hiding this comment.
[SUG] Let's do it compatible with higher versions:
if Rails.version.to_i >= 5
|
Any reason this still hasn't been merged 🤔 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Relevant Issue : Rails 5 does not allow classes to inherit directly from ActiveRecord::Migration without specifying a version. This prevents basic actions such as
db:migrate.Solution
If the rails version is >= 5.x, pass a
migration_versionvariable to themigration_templatefunction to ensure that[5.x]is appended to the migration function declaration.For similar code from a more trusted source, see Devise's implementation.
Concerns
Hey there's no test for this change! But there are no tests for any of the paperclip generator functions. It's late maybe I'll write em later.