This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
Add Errno::EEXIST as possible exception that happens on linking #2532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've merged this without QA because I don't have access to a Windows computer easily, but to confirm: does this work? EEXIST seems like it means cp will also fail? |
|
Yep, it works for me. I have stumbled upon this problem on a paperclip update and debug the problem. Everything works smoothly when this exceptions is caught. |
|
Thank you, @hron ! We'll release 5.2.1 shortly to fix this for everyone. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I try to attach a file on Windows Paperclip fails on trying to make a link with Errno::EEXIST exception.
This exception should be caught as others inside
Paperclip::AbstractAdapter#link_or_copy_file