This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
Rewind file in Storage::Fog if bucket does not exist #2572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 8, 2018
There was a bug in the code where if you created a bucket the file would get read but not rewind on the first pass through (when the bucket didn't exist). So when we went into the retry logic the file would already be read and zero bytes would get copied over from the file. This fixes that by rewinding the file during the retry so it gets correctly copied over the second time around.
natesholland
force-pushed
the
file_rewind_bug
branch
from
8f1ff6f to
5570db4
Compare
|
Thanks for the PR 👍 |
|
I know this is a stretch @sidraval but is there any chance you could port this over into the |
|
@natesholland I've got it on a branch: https://github.com/thoughtbot/paperclip/tree/v4.3.8 but I'm experiencing CI failures that I don't have the bandwidth to deal with at the moment. You're welcome to take a peek, but I don't think I should cut v4.3.8 without passing CI at least. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in the code where if you created a bucket the file would
get read but not rewind on the first pass through (when the bucket
didn't exist). So when we went into the retry logic the file would
already be read and zero bytes would get copied over from the file. This
fixes that by rewinding the file during the retry so it gets correctly
copied over the second time around.