Add support to numericality: :other_than #1004
Conversation
lib/shoulda/matchers/active_model/numericality_matchers/comparison_matcher.rb
Outdated
Show resolved
Hide resolved
lib/shoulda/matchers/active_model/numericality_matchers/comparison_matcher.rb
Outdated
Show resolved
Hide resolved
|
Want it :) |
|
Why did this PR get closed but not merged? |
|
I don't remember closing this PR myself :( I can submit a new one with same changes starting from latest code... maybe it will be better for reviewing and merging |
|
Ah, I just assumed you had closed it because you were tired of this PR sitting around (I don't blame you). If you still have the branch, please reopen! |
|
I would never close for this reason 😂. I'll rebase master and do the changes again. I don't have the branch anymore, but the diff is on this PR. A lot has changed between this PR creation and current code, and I want to be closer to latest work. |
|
lol, thanks guys, looking forward to this feature getting merged. 😂 |
|
New PR is #1282. @wayne5540 thanks for pointing up my mistake on closing this PR. |
Add support to validate numericality of a field when set :other_than comparison