Create initial environment for Rails 5 #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The protected_attributes gem is not compatible for Rails 5, and we don't need it anyway with Strong Parameters.
houndci-bot
reviewed
Apr 23, 2017
| context 'an active_resource model' do | ||
| context 'with the validation context' do | ||
| it 'does not raise an exception' do | ||
| expect { |
There was a problem hiding this comment.
Avoid using {...} for multi-line blocks.
houndci-bot
reviewed
Apr 23, 2017
| context 'an active_resource model' do | ||
| context 'with the validation context' do | ||
| it 'does not raise an exception' do | ||
| expect { |
There was a problem hiding this comment.
Avoid using {...} for multi-line blocks.
guialbuk
pushed a commit
to guialbuk/shoulda-matchers
that referenced
this pull request
Jul 5, 2017
… to 5.0.4 and 4.2.9 in Appraisal Add missing json dependency for rdoc in Rails 4.1 and 4.2 failing in TravisCI Merge pull request thoughtbot#1015 from thoughtbot/master 2 months ago Merge pull request thoughtbot#1014 from guialbuk/rails-5-readme Add installation instructions for Rails 5.0 Merge pull request thoughtbot#943 from guialbuk/fix-933 Fix #tables deprecation in Rails 5.0 and keep compatibility with Rails 4.x Merge pull request thoughtbot#1013 from guialbuk/travis-rails-5 Fix multi-line block code style Add jbuilder to rails 4.2 and 5.0 tests Update appraisal to rails 5.0.2 Add rails-controller-testing gem to rails 5.0 tests Fetch pry gem using HTTPS Don't protect attributes under Rails 5 Don't require ActiveResource tests under Rails 5 capture, silence_stream, and silence_stderr were removed in Rails 5 Exclude Ruby 2.3 from Rails 4.0.x jobs in Travis CI Add specific ruby versions so Travis CI downloads the right rvm binaries Exclude Ruby 2.0 and 2.1 from Rails 5.0 jobs in Travis CI Update Rails versions to 5.0.4 and 4.2.9 in Appraisal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.