Transforms string arguments to symbols for scoped arguments on Unique… #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Feb 18, 2019
spec/unit/shoulda/matchers/active_record/validate_uniqueness_of_matcher_spec.rb
Outdated
Show resolved
Hide resolved
spec/unit/shoulda/matchers/active_record/validate_uniqueness_of_matcher_spec.rb
Outdated
Show resolved
Hide resolved
spec/unit/shoulda/matchers/active_record/validate_uniqueness_of_matcher_spec.rb
Outdated
Show resolved
Hide resolved
spec/unit/shoulda/matchers/active_record/validate_uniqueness_of_matcher_spec.rb
Outdated
Show resolved
Hide resolved
spec/unit/shoulda/matchers/active_record/validate_uniqueness_of_matcher_spec.rb
Outdated
Show resolved
Hide resolved
spec/unit/shoulda/matchers/active_record/validate_uniqueness_of_matcher_spec.rb
Outdated
Show resolved
Hide resolved
…ness Matcher * ActiveRecord allows attributes to be use string or symbol arguments interchangeably. The ValidateUniquenessOfMatcher operates under the assumption that all scope arguments will be defined as symbols. We should transform the scoped arguments to symbol so that exceptions do not get raised. * See #1175
|
@mcmire Just curious if you have a date planned for a new tagged release? |
|
@PhilCoggins I don't have a date planned for the next release, but I'm aware that Rails 6 is around the corner, so my current priority is to resolve all of the Rails 6 related issues (or merge in PRs around them) and put out a new release some time next month. |
|
Thanks so much for this PR! I merged it here: 916f101 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ness Matcher
ActiveRecord allows attributes to be use string or symbol arguments interchangeably.
The ValidateUniquenessOfMatcher operates under the assumption that all scope arguments
will be defined as symbols. We should transform the scoped arguments to symbol
so that exceptions do not get raised.
See validate_uniqueness_of matcher raises exception when scope_to attribute is string #1175