Add minimal support for Rails 6 #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Mar 21, 2019
* Add Rails 6 appraisal to start testing against it. * Fix usage of Module#parent as this is deprecated in Rails 6 in favor of Module#module_parent. * Ensure that we're using the correct version of `sqlite3` and `pg` at all times * When creating classes within tests, ensure that they are removed correctly * Fix detection of has_secure_password in models: Check that InstanceMethodsOnActivation is specifically defined, as Rails 6 no longer has such a module. Co-authored-by: Lee Machin <me@mrl.ee>
mcmire
force-pushed
the
add-support-for-rails-6
branch
2 times, most recently
from
36a4f52 to
ae9bf4a
Compare
|
Hey there! |
|
Hey @palkan — yeah, I do plan on doing it soon. There's a couple of issues left over that I need to address, and I haven't had time lately to work on them, but I'll try to make time within the next couple of weeks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
of Module#module_parent.
sqlite3andpgatall times
correctly
InstanceMethodsOnActivation is specifically defined, as Rails 6 no
longer has such a module.
Closes #1117.
Closes #1167.
Closes #1169.
Closes #1186.