Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove rails 5.1 support #1429

Merged
merged 3 commits into from
Apr 17, 2021
Merged

Remove rails 5.1 support #1429

merged 3 commits into from
Apr 17, 2021

Conversation

vsppedro
Copy link
Collaborator

@vsppedro vsppedro commented Mar 17, 2021 •
edited
Loading

TODO list for Shoulda-matchers 5.0:

For ruby:

  • remove support for 2.5
  • add support for 3.0

For rails:

  • remove support for 4.2
  • remove support for 5.0
  • remove support for 5.1
  • add support for 6.1

After this PR, I'll start adding the missing support. 😄

Before reviewing this PR is necessary to merge the #1428.

@vsppedro vsppedro changed the title Remove rails 5 1 Remove rails 5.1 support Mar 17, 2021
@vsppedro vsppedro force-pushed the remove-rails-5-1 branch 2 times, most recently from 232712a to 3a239b5 Compare March 17, 2021 01:30
@vsppedro vsppedro requested a review from mcmire March 17, 2021 01:48
@vsppedro vsppedro marked this pull request as ready for review March 17, 2021 01:48
@vsppedro vsppedro marked this pull request as draft March 20, 2021 21:14
@vsppedro vsppedro removed the request for review from mcmire March 20, 2021 23:18
@vsppedro vsppedro marked this pull request as ready for review March 23, 2021 21:58
@vsppedro vsppedro requested a review from mcmire March 24, 2021 00:12
@vsppedro
Copy link
Collaborator Author

We are almost there! 🎉

mcmire
mcmire approved these changes Apr 17, 2021
View reviewed changes
Copy link
Collaborator

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo! Looks great!

@vsppedro vsppedro merged commit 50085f0 into master Apr 17, 2021
@vsppedro vsppedro deleted the remove-rails-5-1 branch April 17, 2021 20:13
@vsppedro vsppedro mentioned this pull request Jun 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcmire mcmire mcmire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vsppedro @mcmire