Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use_before_filter, use_after_filter and use_around_filter matchers #1431

Merged
merged 1 commit into from
Mar 21, 2021

Conversation

vsppedro
Copy link
Collaborator

They are only tested on a version that we don't support anymore. What do you think about removing them?

@vsppedro vsppedro requested a review from mcmire March 21, 2021 00:23
Copy link
Collaborator

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this totally makes sense! ✂️ ✂️

@vsppedro
Copy link
Collaborator Author

vsppedro commented Mar 21, 2021

Thank you!

About the next release, I think we are almost there! I'm facing a weird bug with ruby 3.0. I'll detail that later.

Thanks again!

@vsppedro vsppedro merged commit 73deafd into master Mar 21, 2021
@vsppedro vsppedro deleted the remove-callback-matchers branch March 21, 2021 04:10
@vsppedro vsppedro mentioned this pull request Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants