renew deprecated methods #1444
Merged
renew deprecated methods #1444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Because ActiveModel::Errors::attribute_names was not available in Rails 5.2 and 6.0, I decided to use to_hash for compatibility. |
|
Thank you for your contribution! LGTM! |
vsppedro
approved these changes
Jun 12, 2021
|
As for the next release, I plan to wait a few days for more feedback on our latest release, maybe a week or two. Thank you again! |
This was referenced Jul 3, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for providing a nice gem.
In shoulda-matchers@v5.0.0.rc1, still there were deprecated methods for Rails6.1 in a helper method and an unit test, which have been renewed.