Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ruby 3.3.0-rc1 support #1588

Merged
merged 1 commit into from
Dec 21, 2023
Merged

feat: add ruby 3.3.0-rc1 support #1588

merged 1 commit into from
Dec 21, 2023

Conversation

vsppedro
Copy link
Collaborator

No description provided.

@vsppedro vsppedro requested a review from matsales28 as a code owner December 17, 2023 17:51
@vsppedro vsppedro marked this pull request as draft December 17, 2023 17:52
@vsppedro vsppedro removed the request for review from matsales28 December 17, 2023 17:52
@vsppedro vsppedro force-pushed the add-ruby-3.3 branch 3 times, most recently from 6666add to d4666a4 Compare December 21, 2023 00:09
@vsppedro
Copy link
Collaborator Author

We have a problem with Ruby 3.3.0-rc1 and Rails 7.0: https://github.com/thoughtbot/shoulda-matchers/actions/runs/7282196165/job/19844139180?pr=1588

Error: Your Ruby version is 3.3.0.rc1, but your Gemfile specified 3.3.0.

I also opened a issue on Rails: rails/rails#50413

I'm continuing to work on it.

@vsppedro
Copy link
Collaborator Author

vsppedro commented Dec 21, 2023

The problem reported on my previous comment was fixed on Rails 7.1, but it won't be back port because it's in fact a feature.

For the time being, let's exclude the case where Rails is version 7.0.x and Ruby 3.3.0.rc-1.

After merging this PR, let's focus on our next release.

There is two more PRs for it.

One updating the CHANGELOG and other updating the Version.
Examples:

I'm going to work on the Changelog ASAP.

What do you think about working on the other PR, @matsales28? Have you read this(https://github.com/thoughtbot/shoulda-matchers/blob/main/MAINTAINING.md#issuing-a-new-release)?

I recommend making the next release a major one, given that we have discontinued support for certain Ruby and Rails versions.

@vsppedro vsppedro marked this pull request as ready for review December 21, 2023 18:48
@matsales28
Copy link
Member

What do you think about working on the other PR, @matsales28? Have you read this(https://github.com/thoughtbot/shoulda-matchers/blob/main/MAINTAINING.md#issuing-a-new-release)?

I recommend making the next release a major one, given that we have discontinued support for certain Ruby and Rails versions.

Yes! I've set up the ruby gems access for me. I can make the version PR and publish it to ruby gems, no problem!

@vsppedro vsppedro merged commit 027db70 into main Dec 21, 2023
16 checks passed
@vsppedro vsppedro deleted the add-ruby-3.3 branch December 21, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants