Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support deprecated status code symbols. #1637

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Support deprecated status code symbols. #1637

merged 1 commit into from
Jul 5, 2024

Conversation

ioquatix
Copy link
Contributor

No description provided.

@simi
Copy link

simi commented Jun 13, 2024

Just to add a little background, some code names were changed and related constant should not be reached directly to get proper deprecation warning.

@matsales28
Copy link
Member

Just to add a little background, some code names were changed and related constant should not be reached directly to get proper deprecation warning.

It makes sense to me; I triggered the CI, and once it pass, I'm good merging. Thanks for adding that!

@matsales28 matsales28 merged commit 03b0801 into thoughtbot:main Jul 5, 2024
15 checks passed
@ioquatix ioquatix deleted the patch-1 branch July 5, 2024 22:58
@ioquatix
Copy link
Contributor Author

ioquatix commented Jul 5, 2024

Thanks team!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matsales28 matsales28 matsales28 approved these changes

@vsppedro vsppedro Awaiting requested review from vsppedro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ioquatix @simi @matsales28