Uniqueness: Fix when scope set to nil beforehand #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| it 'still accepts if the scope is unset beforehand' do | ||
| record = build_record_validating_uniqueness( | ||
| scopes: [ build_attribute(name: :scope, value: nil) ] |
There was a problem hiding this comment.
Space inside square brackets detected.
Switch the order of how the column type is detected so that string comes last. This fixes a bug where if the scope was a text column but was set to nil before running the matcher, the matcher would fail.
mcmire
force-pushed
the
ew-uniqueness-scope-nil-before
branch
from
aa48800 to
226ce5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #521.
Although the tests already passed before for the simple case, this likely also fixes #607.
Switch the order of how the column type is detected so that string comes
last. This fixes a bug where if the scope was a text column but was set
to nil before running the matcher, the matcher would fail.