Change association matchers to raise a error when the model is missing some declarations #723
Conversation
| @@ -18,6 +18,7 @@ | |||
| require "shoulda/matchers/active_record/define_enum_for_matcher" | |||
| require "shoulda/matchers/active_record/uniqueness" | |||
| require "shoulda/matchers/active_record/validate_uniqueness_of_matcher" | |||
| require "shoulda/matchers/active_record/errors" | |||
There was a problem hiding this comment.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
When using the `have_many` for example the user maybe have some misdeclarations on your model, like missed a has many through that dont declare the has many/belongs to in the through model. In this case ActiveRecord raise specific excepetions like[1]. With this changes we capture the ActiveRecord exception and re-raise as a Shoulda::Matchers exception. [1]: https://github.com/rails/rails/blob/master/activerecord/lib/active_record/associations.rb#L19
Since we raise a exception when we have a invalid model definition some specs are no more needed. Change the model definition to define the right association to fix a broken spec, that expect a right association.
On current release of Rails 4.1 the correct exception was not raised when you define a relationship with a wrong associations. This was fixed on this PR[1]. We need to keep this until the release of Rails 4.1.11. [1]: rails/rails#20324
maurogeorge
force-pushed
the
have_many-through-error
branch
from
291b3b0 to
a2aaeea
Compare
| class Error < StandardError | ||
| def initialize(original_exception) | ||
| message = <<-EOT.strip_heredoc | ||
| Check your models definitions, the following error was raised by ActiveRecord: |
|
Not sure why this is broken on travis, works on my machine™ 😄 I think this is related to If you guys have a idea let me know. |
|
Hi @maurogeorge 👋 |
|
Sorry for the long wait on this. I took these changes and modified them a bit to fail the matcher instead of raising an error. I also made it so that |
Closes #646