Add the qualifier allow_blank to validate_length_of #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename allows_blank_value? to allow_blank_matches? to keep the same conventiion name of the allow_nil_matches?
| def allow_blank_matches? | ||
| if @options.key?(:allow_blank) | ||
| blank_values = ['', ' ', "\n", "\r", "\t", "\f"] | ||
| @options[:allow_blank] == blank_values.all? { |value| allows_value_of(value) } |
|
I'm in need of this feature, is there a reason it hasn't been merged yet? UPDATE I see this it out of date now, would it be merged if it was bought up to date? |
|
@josephbridgwaterrowe Sure. An update for this PR or a new PR for this feature would be welcome 🙂 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.