Adding support to allow_nil option for delegate_method matcher #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 'Expected Person to delegate #hello to #country'\ | ||
| ' object allowing nil', | ||
| 'Method calls sent to Person#country:', | ||
| '1) hello()' |
There was a problem hiding this comment.
Put a comma after the last item of a multiline array.
|
Why did you make a new PR? Just force push to the other PR. (Yes, you can do that 😄) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone! I would like to add support for allow_nil option to delegate_method matcher.
I update rspec-rails version in Appraisals file in order to get some new matchers.