Scope parameters according to Rails version #964
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rails 5 has deprecated the keywords arguments for #permit. This patch scopes the request params according to the ActionPack version. Fixes #867. Supercedes #917 with passing tests. Thank you to @freesteph for helpin' out!
mygulamali
force-pushed
the
fix-keyword-params-for-rails-5
branch
from
35fb146 to
c64468e
Compare
mcmire
reviewed
Sep 23, 2016
| @@ -250,7 +250,10 @@ def matches?(controller) | |||
| parameters_double_registry.register | |||
|
|
|||
| Doublespeak.with_doubles_activated do | |||
| context.__send__(verb, action, request_params) | |||
| scoped = ::ActionPack::VERSION::MAJOR >= 5 | |||
There was a problem hiding this comment.
Thanks for this. We tend to place logic that's dependent on Rails versions in RailsShim, that way everything is in one place. What if you extracted context.__send__ to a method, say, make_controller_request(context, verb, action, options = {})?
Additionally, please note that I won't be able to merge this in until I have Travis running the gem against Rails 5. But I'll at least add this to #960.
|
Closing this PR as it has been superseded by #989, which takes the review comments into account, and is also based on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 5 has deprecated the keywords arguments for #permit. This patch scopes the request params according to the version of Rails.
Fixes #867. Supercedes #917 with passing tests.
Thank you to @freesteph for helpin' out!